-
Notifications
You must be signed in to change notification settings - Fork 36
Revert rbac addition for BuildRun resource #1164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert rbac addition for BuildRun resource #1164
Conversation
Because we will not use Shipwright, We should revert kmm to not have RBAC for Shipwrights resources like BuildRun. This commit reverts to the old RBAC configuration.
✅ Deploy Preview for kubernetes-sigs-kmm ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Hi @TomerNewman. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/unhold |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TomerNewman, ybettan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1164 +/- ##
==========================================
- Coverage 79.09% 73.72% -5.37%
==========================================
Files 51 66 +15
Lines 5109 5877 +768
==========================================
+ Hits 4041 4333 +292
- Misses 882 1382 +500
+ Partials 186 162 -24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
/lgtm |
Because we will not use Shipwright, We should revert kmm to not have RBAC for Shipwrights resources like BuildRun.
This commit reverts to the old RBAC configuration.
Relevant PR - #1156
/cc @ybettan @yevgeny-shnaidman
/hold