VPA for CronJob

[estahn]

Would be great to have the VPA update CronJob resources.

[bskiba]

Seems reasonable, we need to find a consistent way to fetch a labelSelector from a CronJob. (CronJob does not support scale subresource).
@schylek @kgolab FYI

[bskiba]

This should not be very difficult to support. The parts to fix are:

• give VPA recommender permissions to read CronJobs
• add code to return JobSpec.LabelSelector for CronJobs in this switch:

  autoscaler/vertical-pod-autoscaler/pkg/target/fetcher.go

  Line 153 in e79fbee

  switch obj.(type) {

Marking this as help-wanted if anyone wants to pick it up. Will be happy to review.

[estahn]

@bskiba Thanks for your input. I will make it my Friday project and report back.

[schylek]

One small addition: CronJob has to be added to the list of observed controllers as it is already happening for Job.

autoscaler/vertical-pod-autoscaler/pkg/target/fetcher.go

Line 86 in e79fbee

job: factory.Batch().V1().Jobs().Informer(),

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[bskiba]

/remove-lifecycle stale