Some AWS instance types (r5.8xlarge, r5a.8xlarge) are missing

[viggeh]

Hey,

I got an error in cluster-autoscaler using an ASG with r5a.8xlarge instances.

Unable to build proper template node for *: ASG "*" uses the unknown EC2 instance type "r5a.8xlarge"

Looking at

autoscaler/cluster-autoscaler/cloudprovider/aws/ec2_instance_types.go

Line 972 in d9a8661

"r5a.12xlarge": {

I noticed that r5.8xlarge, r5a.8xlarge and r5d.8xlarge are all missing. We do have the 12x and 4x options though. Maybe something went wrong in the last generation run.

[jerrylam]

I'm also looking into that. I wonder if adding a new instance type is as easy as adding a new entry into this ec2_instance_types.go file? If yes, I'm more than happy to add that :)

[Jeffwan]

I can add instances and cherry-pick to all branches, release team will roll out new images next week

[Jeffwan]

Sorry for late response. Just come back from vacation :D

[Jeffwan]

I'm also looking into that. I wonder if adding a new instance type is as easy as adding a new entry into this ec2_instance_types.go file? If yes, I'm more than happy to add that :)

Yes. That's true. Next time you can run go run ec2_instance_types/gen.go to get updated file.

[Jeffwan]

Changes will backport to previous versions

[Jeffwan]

new release already have new instance types. I will close this issue.

[Jeffwan]

/close

[k8s-ci-robot]

@Jeffwan: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.