Add the ability to better pass additional arguments to containers

[Rajat-0]

#1540

[mwielgus]

What is the purpose of this change? You are changing the build infrastructure for VPA ...

[Rajat-0]

@mwielgus I was trying to implement #1540

[mwielgus]

OK, I noticed the bug in the description, but I'm not sure what is your plan in modifying the build scripts.

[Rajat-0]

@mwielgus So if I have to customize the arguments to be passed to the containers, then I have to change in Its pod's DockerFile( Recommender, Admission Controller, Updater)?

[mwielgus]

You are changing the wrong Docker file. For example you should change this one:

https://github.com/kubernetes/autoscaler/blob/master/vertical-pod-autoscaler/pkg/admission-controller/Dockerfile

Instead of the one that is used to compile stuff.

[mfilotto]

Maybe we could move default parameters to CMD as a best practice
https://medium.freecodecamp.org/docker-entrypoint-cmd-dockerfile-best-practices-abc591c30e21

And there is an extra i at the end of updater

[bskiba]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bskiba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [bskiba]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mfilotto]

Any plan to build a new vpa images version to unlock this feature ?
Looking forward to be able to set arguments (set replicas to 1 in my use case)

[Leluke]

Hi how can I take advantage of this option? I wanted my VPA to restart pods even when there is only one replica of each.