Add version field to spec

[tomislater]

According to this document we should also set version field.
Without doing this, it is impossible to deploy VPA on Kubernetes 1.10.

Before:

./hack/vpa-up.sh
Error from server (Invalid): error when creating "STDIN": CustomResourceDefinition.apiextensions.k8s.io "verticalpodautoscalers.autoscaling.k8s.io" is invalid: spec.version: Required value
Error from server (Invalid): error when creating "STDIN": CustomResourceDefinition.apiextensions.k8s.io "verticalpodautoscalercheckpoints.autoscaling.k8s.io" is invalid: spec.version: Required value
clusterrole.rbac.authorization.k8s.io/system:metrics-reader created
clusterrole.rbac.authorization.k8s.io/system:vpa-actor created
clusterrole.rbac.authorization.k8s.io/system:vpa-checkpoint-actor created
clusterrole.rbac.authorization.k8s.io/system:evictioner created
clusterrolebinding.rbac.authorization.k8s.io/system:metrics-reader created
clusterrolebinding.rbac.authorization.k8s.io/system:vpa-actor created
clusterrolebinding.rbac.authorization.k8s.io/system:vpa-checkpoint-actor created
clusterrole.rbac.authorization.k8s.io/system:vpa-target-reader created
clusterrolebinding.rbac.authorization.k8s.io/system:vpa-vpa-target-reader-binding created
clusterrolebinding.rbac.authorization.k8s.io/system:vpa-evictionter-binding created
serviceaccount/vpa-admission-controller created
clusterrole.rbac.authorization.k8s.io/system:admission-controller created
clusterrolebinding.rbac.authorization.k8s.io/system:admission-controller created
serviceaccount/vpa-updater created
deployment.extensions/vpa-updater created
serviceaccount/vpa-recommender created
deployment.extensions/vpa-recommender created
Generating certs for the VPA Admission Controller in /tmp/vpa-certs.
Generating RSA private key, 2048 bit long modulus
................................+++++
............................................................................+++++
e is 65537 (0x10001)
Generating RSA private key, 2048 bit long modulus
.............................+++++
........................+++++
e is 65537 (0x10001)
Signature ok
subject=/CN=vpa-webhook.kube-system.svc
Getting CA Private Key
Uploading certs to the cluster.
secret/vpa-tls-certs created
Deleting /tmp/vpa-certs.
deployment.extensions/vpa-admission-controller created
service/vpa-webhook created

After:

./hack/vpa-up.sh
customresourcedefinition.apiextensions.k8s.io/verticalpodautoscalers.autoscaling.k8s.io created
customresourcedefinition.apiextensions.k8s.io/verticalpodautoscalercheckpoints.autoscaling.k8s.io created
clusterrole.rbac.authorization.k8s.io/system:metrics-reader created
clusterrole.rbac.authorization.k8s.io/system:vpa-actor created
clusterrole.rbac.authorization.k8s.io/system:vpa-checkpoint-actor created
clusterrole.rbac.authorization.k8s.io/system:evictioner created
clusterrolebinding.rbac.authorization.k8s.io/system:metrics-reader created
clusterrolebinding.rbac.authorization.k8s.io/system:vpa-actor created
clusterrolebinding.rbac.authorization.k8s.io/system:vpa-checkpoint-actor created
clusterrole.rbac.authorization.k8s.io/system:vpa-target-reader created
clusterrolebinding.rbac.authorization.k8s.io/system:vpa-vpa-target-reader-binding created
clusterrolebinding.rbac.authorization.k8s.io/system:vpa-evictionter-binding created
serviceaccount/vpa-admission-controller created
clusterrole.rbac.authorization.k8s.io/system:admission-controller created
clusterrolebinding.rbac.authorization.k8s.io/system:admission-controller created
serviceaccount/vpa-updater created
deployment.extensions/vpa-updater created
serviceaccount/vpa-recommender created
deployment.extensions/vpa-recommender created
Generating certs for the VPA Admission Controller in /tmp/vpa-certs.
Generating RSA private key, 2048 bit long modulus
..............................................................................................................................................+++++
.........................................................................................+++++
e is 65537 (0x10001)
Generating RSA private key, 2048 bit long modulus
..........................................................................................................+++++
............................+++++
e is 65537 (0x10001)
Signature ok
subject=/CN=vpa-webhook.kube-system.svc
Getting CA Private Key
Uploading certs to the cluster.
secret/vpa-tls-certs created
Deleting /tmp/vpa-certs.
deployment.extensions/vpa-admission-controller created
service/vpa-webhook created

[tomislater]

/assign @MaciekPytel

[mwielgus]

cc: @schylek

[schylek]

Thank you for contribution. However please note that v1beta1 will be deprecated soon.

/lgtm

[k8s-ci-robot]

@schylek: changing LGTM is restricted to assignees, and only kubernetes/autoscaler repo collaborators may be assigned issues.

In response to this:

Thank you for contribution. However please note that v1beta1 will be deprecated soon.

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mwielgus]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mwielgus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bskiba]

This is just FYI, the version field in CRD is deprecated starting from 1.11, so it will be ignored in 1.11+