Skip to content

Add prices for all machine types, adjust e2 fractional VM pricing #3119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2020
Merged

Add prices for all machine types, adjust e2 fractional VM pricing #3119

merged 1 commit into from
May 7, 2020

Conversation

brett-elliott
Copy link
Contributor

This change

  • Adds prices for all machine types.

  • Adjusts pricing for e2-micro and e2-small to be greater than e2-medium. See comment for more details.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 7, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @brett-elliott!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 7, 2020
@MaciekPytel
Copy link
Contributor

Thanks! It seems like it may also be worth cherry-picking into patch releases. WDYT?
/lgtm
/approve

One minor comment: maybe squash to one commit? It seems like a simple enough change and it will make cherry-picking easier.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MaciekPytel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 7, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2020
@brett-elliott
Added prices for all machine types. Also adjusted e2-small and e2-micro.
5e0611a 
e2-micro and e2-small have allocatable set too high resulting in
overcommit. To make cluster autoscaler prefer e2-medium given the choice
between the three machine types, the prices for e2-micro and e2-small
are artificially set to be higher than the price of e2-medium.
@MaciekPytel
Copy link
Contributor

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit eec4a36 into kubernetes:master May 7, 2020
@brett-elliott brett-elliott deleted the e2 branch May 21, 2020 11:18
@brett-elliott brett-elliott mentioned this pull request Jul 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aleksandra-malinowska aleksandra-malinowska Awaiting requested review from aleksandra-malinowska

@losipiuk losipiuk Awaiting requested review from losipiuk

Assignees

@MaciekPytel MaciekPytel

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brett-elliott @k8s-ci-robot @MaciekPytel