remove unsupported functionality from cluster-api provider #5249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this change removes the code for the `Labels` and `Taints` interface functions of the clusterapi provider when scaling from zero. The body of these functions was added erronesouly and the Cluster API community is still deciding on how these values will be expose to the autoscaler. also updates the tests and readme to be more clear about the usage of labels and taints when scaling from zero.
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
the
approved
asm582
reviewed
Oct 15, 2022
| "node.kubernetes.io/instance-type": "instance1", | ||
| "anotherLabel": "nodeValue", // This should not be copied as it is not a well known label | ||
| }, | ||
| nodegroupLabels: map[string]string{ |
There was a problem hiding this comment.
is it the case that nodegroup labels will be added to node(s) under the .metadata/labels level?
There was a problem hiding this comment.
yes, when the node is created the labels will be added. but, we currently don't have a mechanism from the cluster-api side about where to find those labels, this issue is related kubernetes-sigs/cluster-api#7006
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko, mwielgus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
navinjoy
pushed a commit
to navinjoy/autoscaler
that referenced
this pull request
Oct 26, 2022
remove unsupported functionality from cluster-api provider
elmiko
added a commit
to joelsmith/autoscaler
that referenced
this pull request
Feb 16, 2023
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. [0]: kubernetes#5249
cloud-team-bot bot
pushed a commit
to openshift-cloud-team/kubernetes-autoscaler
that referenced
this pull request
May 9, 2023
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. [0]: kubernetes#5249
JoelSpeed
pushed a commit
to openshift-cloud-team/kubernetes-autoscaler
that referenced
this pull request
May 10, 2023
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. [0]: kubernetes#5249
JoelSpeed
pushed a commit
to openshift-cloud-team/kubernetes-autoscaler
that referenced
this pull request
May 10, 2023
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. [0]: kubernetes#5249
JoelSpeed
pushed a commit
to openshift-cloud-team/kubernetes-autoscaler
that referenced
this pull request
May 11, 2023
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. [0]: kubernetes#5249
cloud-team-bot bot
pushed a commit
to openshift-cloud-team/kubernetes-autoscaler
that referenced
this pull request
May 11, 2023
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. [0]: kubernetes#5249
elmiko
added a commit
to openshift-cloud-team/kubernetes-autoscaler
that referenced
this pull request
Jun 1, 2023
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
elmiko
added a commit
to openshift-cloud-team/kubernetes-autoscaler
that referenced
this pull request
Jun 2, 2023
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
cloud-team-bot bot
pushed a commit
to openshift-cloud-team/kubernetes-autoscaler
that referenced
this pull request
Jul 3, 2023
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
cloud-team-bot bot
pushed a commit
to openshift-cloud-team/kubernetes-autoscaler
that referenced
this pull request
Jul 6, 2023
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
cloud-team-bot bot
pushed a commit
to openshift-cloud-team/kubernetes-autoscaler
that referenced
this pull request
Jul 10, 2023
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
cloud-team-bot bot
pushed a commit
to openshift-cloud-team/kubernetes-autoscaler
that referenced
this pull request
Jul 13, 2023
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
cloud-team-bot bot
pushed a commit
to openshift-cloud-team/kubernetes-autoscaler
that referenced
this pull request
Jul 17, 2023
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
cloud-team-bot bot
pushed a commit
to openshift-cloud-team/kubernetes-autoscaler
that referenced
this pull request
Jul 20, 2023
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
cloud-team-bot bot
pushed a commit
to openshift-cloud-team/kubernetes-autoscaler
that referenced
this pull request
Jul 24, 2023
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
elmiko
added a commit
to elmiko/kubernetes-autoscaler
that referenced
this pull request
Mar 3, 2025
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
elmiko
added a commit
to elmiko/kubernetes-autoscaler
that referenced
this pull request
Mar 11, 2025
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
elmiko
added a commit
to elmiko/kubernetes-autoscaler
that referenced
this pull request
Mar 27, 2025
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
cloud-team-bot bot
pushed a commit
to openshift-cloud-team/kubernetes-autoscaler
that referenced
this pull request
May 12, 2025
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
cloud-team-bot bot
pushed a commit
to openshift-cloud-team/kubernetes-autoscaler
that referenced
this pull request
Jun 19, 2025
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
cloud-team-bot bot
pushed a commit
to openshift-cloud-team/kubernetes-autoscaler
that referenced
this pull request
Jun 23, 2025
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
cloud-team-bot bot
pushed a commit
to openshift-cloud-team/kubernetes-autoscaler
that referenced
this pull request
Jul 3, 2025
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
joelsmith
pushed a commit
to joelsmith/autoscaler
that referenced
this pull request
Jul 24, 2025
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
joelsmith
pushed a commit
to joelsmith/autoscaler
that referenced
this pull request
Jul 24, 2025
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
joelsmith
pushed a commit
to joelsmith/autoscaler
that referenced
this pull request
Jul 24, 2025
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
joelsmith
pushed a commit
to joelsmith/autoscaler
that referenced
this pull request
Jul 24, 2025
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
joelsmith
pushed a commit
to joelsmith/autoscaler
that referenced
this pull request
Jul 24, 2025
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
cloud-team-bot bot
pushed a commit
to openshift-cloud-team/kubernetes-autoscaler
that referenced
this pull request
Jul 28, 2025
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
joelsmith
pushed a commit
to joelsmith/autoscaler
that referenced
this pull request
Jul 31, 2025
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
joelsmith
pushed a commit
to joelsmith/autoscaler
that referenced
this pull request
Jul 31, 2025
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
joelsmith
pushed a commit
to joelsmith/autoscaler
that referenced
this pull request
Aug 19, 2025
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
joelsmith
pushed a commit
to joelsmith/autoscaler
that referenced
this pull request
Aug 19, 2025
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
joelsmith
pushed a commit
to joelsmith/autoscaler
that referenced
this pull request
Aug 19, 2025
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
joelsmith
pushed a commit
to joelsmith/autoscaler
that referenced
this pull request
Aug 21, 2025
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
joelsmith
pushed a commit
to joelsmith/autoscaler
that referenced
this pull request
Aug 21, 2025
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
joelsmith
pushed a commit
to joelsmith/autoscaler
that referenced
this pull request
Aug 21, 2025
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
cloud-team-bot bot
pushed a commit
to openshift-cloud-team/kubernetes-autoscaler
that referenced
this pull request
Aug 25, 2025
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
cloud-team-bot bot
pushed a commit
to openshift-cloud-team/kubernetes-autoscaler
that referenced
this pull request
Sep 25, 2025
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
cloud-team-bot bot
pushed a commit
to openshift-cloud-team/kubernetes-autoscaler
that referenced
this pull request
Sep 29, 2025
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
maxcao13
pushed a commit
to maxcao13/autoscaler
that referenced
this pull request
Oct 1, 2025
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
cloud-team-bot bot
pushed a commit
to openshift-cloud-team/kubernetes-autoscaler
that referenced
this pull request
Oct 2, 2025
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
joelsmith
pushed a commit
to joelsmith/autoscaler
that referenced
this pull request
Oct 2, 2025
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
joelsmith
pushed a commit
to joelsmith/autoscaler
that referenced
this pull request
Oct 3, 2025
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
joelsmith
pushed a commit
to joelsmith/autoscaler
that referenced
this pull request
Oct 8, 2025
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
cloud-team-bot bot
pushed a commit
to openshift-cloud-team/kubernetes-autoscaler
that referenced
this pull request
Oct 16, 2025
This change re-adds the machine api support for labels and taints on node groups. The code was removed upstream as it is openshift specific, see this pull request[0]. It also adds in the functionality of the upstream override annotation for labels and taints[1] to support https://issues.redhat.com/browse/MIXEDARCH-259 [0]: kubernetes#5249 [1]: kubernetes#5382
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which component this PR applies to?
cluster-autoscaler
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
this change removes the code for the
LabelsandTaintsinterface functions of the clusterapi provider when scaling from zero. The body of these functions was added erronesouly and the Cluster API community is still deciding on how these values will be expose to the autoscaler.also updates the tests and readme to be more clear about the usage of labels and taints when scaling from zero.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: