Skip to content

Conversation

kei-gnu
Copy link
Contributor

@kei-gnu kei-gnu commented Jun 4, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR improves code readability. Specifically, it corrects the spacing between elements in the verbs list and the space before a comment.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 4, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 4, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: kei-gnu / name: Keita Tomita (567b082)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 4, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @kei-gnu!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 4, 2023
@k8s-ci-robot k8s-ci-robot requested a review from drmorr0 June 4, 2023 07:36
@k8s-ci-robot k8s-ci-robot added the area/provider/aws Issues or PRs related to aws provider label Jun 4, 2023
@k8s-ci-robot k8s-ci-robot requested a review from gjtempleton June 4, 2023 07:36
@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 4, 2023
@kei-gnu kei-gnu changed the title Fix comment and list format Add whitespace in comments and lists Jun 4, 2023
@Shubham82
Copy link
Contributor

Shubham82 commented Jun 5, 2023

Hi @kei-gnu
Please check and update the same things in the following files under the AWS example directory:

cluster-autoscaler-multi-asg.yaml
cluster-autoscaler-one-asg.yaml
cluster-autoscaler-run-on-control-plane.yaml

@kei-gnu kei-gnu force-pushed the fix-comment-and-list-formatting branch from 0395e53 to dd9188e Compare June 5, 2023 09:32
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 5, 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit: also remove the whitespace from the comment done on line no. 174

@kei-gnu kei-gnu force-pushed the fix-comment-and-list-formatting branch from dd9188e to 567b082 Compare June 5, 2023 09:41
@Shubham82
Copy link
Contributor

Thanks, @kei-gnu
Changes look good to me.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2023
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kei-gnu, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1d0a75c into kubernetes:master Jun 5, 2023
@kei-gnu kei-gnu deleted the fix-comment-and-list-formatting branch June 5, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants