Adds support for startup taints and extends support for status taints #6132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
size/L
cluster-autoscaler/cloudprovider/oci/nodepools/consts/annotations.go
Outdated
Show resolved
Hide resolved
| // FilterOutNodesWithIgnoredTaints override the condition status of the given nodes to mark them as NotReady when they have | ||
| // filtered taints. | ||
| func FilterOutNodesWithIgnoredTaints(ignoredTaints TaintKeySet, allNodes, readyNodes []*apiv1.Node) ([]*apiv1.Node, []*apiv1.Node) { | ||
| func FilterOutNodesWithIgnoredTaints(taintConfig TaintConfig, allNodes, readyNodes []*apiv1.Node) ([]*apiv1.Node, []*apiv1.Node) { |
There was a problem hiding this comment.
FilterOutNodesWithStartupTaints
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atwamahmoud, BigDarkClown The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
panicstevenson
pushed a commit
to airbnb/autoscaler
that referenced
this pull request
Aug 24, 2024
…port Adds support for startup taints and extends support for status taints
panicstevenson
pushed a commit
to airbnb/autoscaler
that referenced
this pull request
Aug 24, 2024
…port Adds support for startup taints and extends support for status taints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind cleanup
What this PR does / why we need it:
Following up on PR #5659,
startup-taintflag is added and combined withignore-taintflag so both will have the same effectstartup-taint.cluster-autoscaler.kubernetes.io/is added to be similar toignore-taint.cluster-autoscaler.kubernetes.io/and behaves the samestatus-taintflag is added and passed to autoscaling optionsstatus-taint.cluster-autoscaler.kubernetes.io/is added to ignore nodes with taints starting with it when scaling up.TaintConfigto have prefixes list instead of relying on constant hardcoded valuesWhich issue(s) this PR fixes:
Allows status-taints to be specified by the users in addition to supporting taints with prefix
status-taint.cluster-autoscaler.kubernetes.io/Does this PR introduce a user-facing change?