Skip to content

Fixing cluster-autoscaler docs to point to correct tutorial for auto-discovery #6172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2023
Merged

Fixing cluster-autoscaler docs to point to correct tutorial for auto-discovery #6172

merged 2 commits into from
Oct 3, 2023

Conversation

jatinbedi
Copy link
Contributor

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Fixes the documentation to point to the correct documentation for auto-discovery for cluster-autoscaler

Which issue(s) this PR fixes:

Fixes #6171

Special notes for your reviewer:

The AWS documentation referenced in the current doc does not exist anymore and the official AWS docs were updated to point to this repo a while ago.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Oct 3, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 3, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 3, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @jatinbedi!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 3, 2023
@k8s-ci-robot k8s-ci-robot added area/provider/aws Issues or PRs related to aws provider area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 3, 2023
@jatinbedi
Copy link
Contributor Author

/trick-or-treat

@k8s-ci-robot
Copy link
Contributor

@jatinbedi: candy image

In response to this:

/trick-or-treat

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@drmorr0
Copy link
Contributor

drmorr0 commented Oct 3, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: drmorr0, jatinbedi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit b8424a1 into kubernetes:master Oct 3, 2023
@jatinbedi jatinbedi changed the title Fixing clutter-autoscaler docs to point to correct tutorial for auto-discovery Fixing cluster-autoscaler docs to point to correct tutorial for auto-discovery Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drmorr0 drmorr0 Awaiting requested review from drmorr0

@gjtempleton gjtempleton Awaiting requested review from gjtempleton

Assignees

@drmorr0 drmorr0

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken hyperlink in the documentation for Auto-Discovery
3 participants
@jatinbedi @k8s-ci-robot @drmorr0