Skip to content

Support using in-cluster kubeconfig #7156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 20, 2024
Merged

Support using in-cluster kubeconfig #7156

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ee6d4f9
Add in cluster kubeconfig config
Duke0404 Jul 30, 2024
ed38cbb
Add unique error message for when in-cluster config is not found
Duke0404 Jul 30, 2024
5420a95
Merge branch 'kubernetes:master' into master
Duke0404 Aug 13, 2024
1dba38e
Run gofmt
Duke0404 Aug 14, 2024
23e8371
Merge branch 'kubernetes:master' into master
Duke0404 Aug 19, 2024
351748c
Remove go formatting for unchanged files
Duke0404 Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions cluster-autoscaler/utils/kubernetes/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,10 @@ import (
)

const (
failedToBuildConfigErr = "Failed to build config"
failedToParseK8sUrlErr = "Failed to parse Kubernetes url"
failedToBuildClientConfigErr = "Failed to build Kubernetes client configuration"
failedToBuildConfigErr = "Failed to build config"
failedToParseK8sUrlErr = "Failed to parse Kubernetes url"
failedToBuildClientConfigErr = "Failed to build Kubernetes client configuration"
failedToFindInClusterConfigErr = "Failed to find in-cluster config"
)

// CreateKubeClient creates kube client based on AutoscalingOptions.KubeClientOptions
Expand All @@ -50,7 +51,7 @@ func GetKubeConfig(opts config.KubeClientOptions) *rest.Config {
if err != nil {
klog.Fatalf("%v: %v", failedToBuildConfigErr, err)
}
} else {
} else if opts.Master != "" {
url, err := url.Parse(opts.Master)
if err != nil {
klog.Fatalf("%v: %v", failedToParseK8sUrlErr, err)
Expand All @@ -60,8 +61,12 @@ func GetKubeConfig(opts config.KubeClientOptions) *rest.Config {
if err != nil {
klog.Fatalf("%v: %v", failedToBuildClientConfigErr, err)
}
} else {
kubeConfig, err = rest.InClusterConfig()
if err != nil {
klog.Fatalf("%v: %v", failedToFindInClusterConfigErr, err)
}
}

kubeConfig.QPS = opts.KubeClientQPS
kubeConfig.Burst = opts.KubeClientBurst
kubeConfig.ContentType = opts.APIContentType
Expand Down
Loading