Skip to content

Conversation

ialidzhikov
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Right now, it is clear where the prometheus and external-metrics flags start but it is not clear where they end.
For example, --memory-saver is not a prometheus history provider related flag but it appears so.
This PR uses the already existing pattern of grouping flags into dedicated var blocks (see the rest of the flags; there are other groups like aggregation configuration flags and post processor flags).

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 27, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 27, 2024
@raywainman
Copy link
Member

/lgtm

Thanks for the cleanup

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2024
@adrianmoisey
Copy link
Member

/lgtm

I'm a huge fan of changes like this, they seem super small, but make the project that much easier to work on. Over time these add up making for a nice neat easy to work on project. Thanks for doing it!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2024
@voelzmo
Copy link
Contributor

voelzmo commented Dec 3, 2024

/approve

Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov, voelzmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit cd58f3f into kubernetes:master Dec 3, 2024
7 checks passed
@ialidzhikov ialidzhikov deleted the nit/vpa-recommender-flags branch December 17, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants