-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Fix typo in custom memory bump-up documentation #7588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Move max function to the start of the expression to match the behavior of the recommender: https://github.com/kubernetes/autoscaler/blob/c44d4f00334f2d76410c237d4675eba7c49bd3df/vertical-pod-autoscaler/pkg/recommender/model/container.go#L194-L196
The committers listed above are authorized under a signed CLA. |
Welcome @WalkerMills! |
Hi @WalkerMills. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm Good catch, thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: voelzmo, WalkerMills The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
This PR modifies the expression in the examples for how the recommender computes an increased memory recommendation after an OOM event to match the behavior of the code and the following documentation. The expression is written as
used + max(minimum bump, used * bump up ratio)
, when it should bemax(used + minimum bump, used * bump up ratio)
:autoscaler/vertical-pod-autoscaler/pkg/recommender/model/container.go
Lines 194 to 196 in c44d4f0
I proofread the remaining examples and did not find any other obvious errors, grammar issues, broken links, etc.
Which issue(s) this PR fixes:
None, will file tracking issue if necessary 🤷
Special notes for your reviewer:
This is a trivial typo fix, should be a quick review
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
N/A