Skip to content

Conversation

adrianmoisey
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

I noticed https://pkg.go.dev/vuln/GO-2024-3333 and decided to fix it (even though the VPA isn't using this), but this reduces the number of CVEs shipped with the VPA.
While there, I ran Trivy on the e2e files, and fixed a few there too.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


For this CVE: https://pkg.go.dev/vuln/GO-2024-3333

Whil it isn't used in the VPA, it's great to keep CVEs shipped with the
VPA down
- https://pkg.go.dev/vuln/GO-2023-2113
- https://pkg.go.dev/vuln/GO-2024-3333
- https://pkg.go.dev/vuln/GO-2024-3321

Trivy discovered these. While not critical, since it's for e2e tests,
it's good to keep on top of these.
@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 19, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/vertical-pod-autoscaler labels Dec 19, 2024
@k8s-ci-robot k8s-ci-robot requested a review from voelzmo December 19, 2024 15:54
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 19, 2024
@voelzmo
Copy link
Contributor

voelzmo commented Dec 20, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianmoisey, voelzmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@voelzmo
Copy link
Contributor

voelzmo commented Dec 20, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit 883fa4f into kubernetes:master Dec 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants