[cluster-autoscaler-release-1.34] Fix a race condition in TestNodeLoadFromExistingTaints #8594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestNodeLoadFromExistingTaints creates a currentTime variable set to time.Now(), and a bunch of test objects with time values offset from that variable. This is all standard practice, but then the test iterates over test cases, calls t.Parallel(), and overwrites currentTime with time.Now() again. This makes go test -race fail, because multiple goroutines are writing currentTime at once. It also doesn't seem to make sense in the context of the test, because the other test objects are still offset from the original value. Removing the second write to currentTime seems to be the correct fix here. Also renamed one import because it collided with a local variable name used throughout this test file.
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
size/XS
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, k8s-infra-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
merged commit ae7925c
into
kubernetes:cluster-autoscaler-release-1.34
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #8588
/assign jackfrancis