-
Notifications
You must be signed in to change notification settings - Fork 1.5k
KEP-4601: Graduate authorize with selector to stable #5326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
/lgtm |
@@ -3,3 +3,5 @@ alpha: | |||
approver: "@wojtek-t" | |||
beta: | |||
approver: "@wojtek-t" | |||
stable: | |||
approver: "@wojtek-t" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jpbetz signed up to take this one (I'm pairing / shadowing)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we're generally not trying to switch in the middle of lifecycle.
@@ -42,4 +42,5 @@ disable-supported: true | |||
|
|||
# The following PRR answers are required at beta release | |||
metrics: | |||
- find-metric-for-failed-authorization |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears this name was never actually used? So we're just updating the metadata here, not renaming/removing anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's my understanding too
/approve PRR /hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/sig auth
/cc @deads2k
for sig-auth
/cc @wojtek-t
for PRR