-
Notifications
You must be signed in to change notification settings - Fork 208
Add an option to forbid tag arguments #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Gavin Lam <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gavinkflam The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @gavinkflam! |
Hi @gavinkflam. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
Part of kubernetes/kubernetes#130358
ExtractCommentTags
is deprecated. Old tags are not in function style so the migration toExtractFunctionStyleCommentTags
is not straightforward. This new option offers an easier migration path to parse non-function style tags.We have agreed that we want to be strict and have the code generator fail with an error if an unexpected argument is present. Refer to the discussion here.
This can unblock the migration of
ExtractCommentTags
usages in kube-openapi, and eliminate an utility function introduced in kubernetes/kubernetes#131711.cc @jpbetz @yongruilin