Skip to content

Fix deferInLoop error #10387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2023
Merged

Fix deferInLoop error #10387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions internal/nginx/maxmind.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,20 +179,19 @@ func downloadDatabase(dbName string) error {
if !strings.HasSuffix(header.Name, mmdbFile) {
continue
}
return func() error {
outFile, err := os.Create(path.Join(geoIPPath, mmdbFile))
if err != nil {
return err
}

outFile, err := os.Create(path.Join(geoIPPath, mmdbFile))
if err != nil {
return err
}

//nolint:gocritic // TODO: will fix it on a followup PR
defer outFile.Close()

if _, err := io.CopyN(outFile, tarReader, header.Size); err != nil {
return err
}
defer outFile.Close()

return nil
if _, err := io.CopyN(outFile, tarReader, header.Size); err != nil {
return err
}
return nil
}()
}
}

Expand Down