Skip to content

Add cloudkms.cryptoKeyEncrypterDecrypter role to empower_group_for_kms #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2019
Merged

Add cloudkms.cryptoKeyEncrypterDecrypter role to empower_group_for_kms #441

merged 1 commit into from
Oct 30, 2019

Conversation

justaugustus
Copy link
Member

Without this, k8s-infra-release-admins will not be able to
encrypt/decrypt assets, which will be necessary to manage the
k8s-release-robot GitHub token, among other things in the future.

Continuation of #434.

Here's the error:

gcloud kms encrypt --location global --keyring <KEYRING> --key <KEY> --ciphertext-file=- --plaintext-file=<(echo -n '<GITHUB_TOKEN>')
ERROR: (gcloud.kms.encrypt) PERMISSION_DENIED: Permission 'cloudkms.cryptoKeyVersions.useToEncrypt' denied on resource 'projects/k8s-staging-release-test/locations/global/keyRings/<KEYRING>/cryptoKeys/<KEY>' (or it may not exist).

/assign @cblecker @thockin
/sig release

Signed-off-by: Stephen Augustus [email protected]

@justaugustus
Add cloudkms.cryptoKeyEncrypterDecrypter role to empower_group_for_kms
43f4175 
Without this, k8s-infra-release-admins will not be able to
encrypt/decrypt assets, which will be necessary to manage the
k8s-release-robot GitHub token, among other things in the future.

Signed-off-by: Stephen Augustus <[email protected]>
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. wg/k8s-infra labels Oct 30, 2019
thockin
thockin reviewed Oct 30, 2019
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2019
@thockin thockin added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f9d78eb into kubernetes:master Oct 30, 2019
@thockin
Copy link
Member

thockin commented Oct 30, 2019

activated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@cblecker cblecker Awaiting requested review from cblecker

@nikhita nikhita Awaiting requested review from nikhita

Assignees

@cblecker cblecker

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@justaugustus @k8s-ci-robot @thockin @cblecker