releng: Grant access to push images in build-image GCP project #603
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
lgtm
|
@dims I'm not sure if there are not some internal priviliges for that group which we should discuss with googlers? Please clarify and if everything is all right unhold the PR. /hold |
k8s-ci-robot
added
the
do-not-merge/hold
OWNERS_ALIASES
Outdated
| @@ -0,0 +1,23 @@ | |||
| aliases: | |||
| sig-release-approvers: | |||
There was a problem hiding this comment.
how do you currently keep this in sync across repos? :)
There was a problem hiding this comment.
@dims -- I do a quarterly review/update on the SIG Release OWNERS, which is coming up soon.
There was a problem hiding this comment.
I'm -1 on this. kube-cross is a small but critical part of the chain of images. Let's start small with a few folks who want to be engaged in this, then we can develop policies and open it up to more (and I'd be open to at that point handing it over completely to sig-release).
I'd suggest we start with @justaugustus, @BenTheElder, @listx, @dims, and myself. I'm open to adding a couple others from release if they want to explicitly volunteer to join the fun in cleaning this up.
Delegate access to the following contributors to push/promote build images e.g., kube-cross: - BenTheElder - cblecker - dims - justaugustus - listx Signed-off-by: Stephen Augustus <[email protected]>
justaugustus
force-pushed
the
build-image-owners
branch
from
eeaa9b4 to
fdd3955
Compare
k8s-ci-robot
removed
the
lgtm
justaugustus
changed the title
|
@cblecker -- SGTM. Updated to that effect. |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
| @@ -0,0 +1,10 @@ | |||
| # See the OWNERS docs at https://go.k8s.io/owners | |||
|
|
|||
| approvers: | |||
There was a problem hiding this comment.
Actually, I think manifests/... should NOT have OWNERS files - that's more privileged than merely pushing a new image.
|
LGTM modulo #603 (comment) which is resolved already :-) |
One of the follow-up items in our quarterly golang update is to transition ownership of Golang bumps to the @kubernetes/release-engineering group. Part of the Golang bump is updating the
kube-crossimage, which today can only be done by a few Googlers (@BenTheElder, @javier-b-perez, @listx).This PR grants access to push & promote images in the
k8s-staging-build-imageGCP project (where thekube-crossimage will live) to the following contributors:Once we've defined policies for handling these images, we'll expand the scope of this group to include the @kubernetes/release-managers.
Signed-off-by: Stephen Augustus [email protected]
ref: kubernetes/release#1133, kubernetes/kubernetes#88562