Remove references to k8s-staging-release-test #947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
wg/k8s-infra
approved
|
/area release-eng |
k8s-ci-robot
added
the
area/release-eng
3 tasks
| @@ -217,16 +215,6 @@ for repo in "${RELEASE_STAGING_PROJECTS[@]}"; do | |||
| color 6 "Empowering ${RELEASE_VIEWERS} as project viewers in ${PROJECT}" | |||
| empower_group_as_viewer "${PROJECT}" "${RELEASE_VIEWERS}" | |||
|
|
|||
| # TODO(justaugustus): Remove once the k8s-releng-prod GCP project is | |||
There was a problem hiding this comment.
Just for reference...
Moving releng KMS was done as part of kubernetes/release#1163.
|
/lgtm Agreed we should hold deletion until working hours. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encountered while running
ensure-staging-storage.shfor all projects (ref: #857 (comment)).The change that caused this (#742) landed 2020-04-13. Taking ~2 months to surface isn't great.
Per #857 (comment) I think this just about closes out kubernetes/release#1161 but I'm avoiding using the "fixes" keyword to ensure we can verify.
/hold
We don't have automated deletion of projects so someone (probably me) will have to manually delete k8s-staging-release-test to finish this. I'm not about to do so off-hours.