hetzner: Add support for Object Storage #17453
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
/cc @rifelpet |
|
/test pull-kops-e2e-k8s-gce-ipalias |
| return kops.CloudProviderAzure, nil | ||
| case strings.HasPrefix(path, "do://"): | ||
| return kops.CloudProviderDO, nil | ||
| case strings.HasPrefix(path, "hos://"): |
There was a problem hiding this comment.
Nit: do they use this prefix elsewhere? I'm just wondering whether we're going to have to change it...
There was a problem hiding this comment.
They don't use any prefix or acronym. Unless we want to use hetzner://, I think this is good as is.
Also, in the future, we could add aliases without too much trouble.
k8s-ci-robot
added
lgtm
|
/approve I do wonder about that prefix, but it doesn't look too hard to change / support two prefixes if we need to |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
Closes #17147