-
Notifications
You must be signed in to change notification settings - Fork 41.5k
[WIP] Fix DRAConsumableCapacity to be able to allocate the same device that previously consumed the counterSet #134103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Sunyanan Choochotkaew <[email protected]>
… previously consumed the counterSet Signed-off-by: Sunyanan Choochotkaew <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sunya-ch The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes the issue when enabling both DRAPartitionableDevices and ConsumableCapacity.
This PR updates the present
allow-multiple-allocations-with-partitionable-device
test case to properly confirm that setting the allowMultipleAllocations will not break the current functionality of PartitionableDevices.Additionally, it adds a new test case
consumable-capacity-with-partitionable-device-multiple-capacity-pools
which can confirm this bug fix.Simplified test case
counterSet0: 4
device1 (allowMultipleAllocations): consume 2 from counterSet0
device2 (allowMultipleAllocations): consume 4 from counterSet0
device3 (allowMultipleAllocations): consume 2 from counterSet0
req0: request capacity 1
req2: request capacity 2
req1: (subrequest prioritize 4 > 2, request capacity 1)
Expect
Which issue(s) this PR is related to:
Fixes #134100
Special notes for your reviewer:
Will rebase and left only one last commit after #133706 merge
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: