Skip to content

Conversation

sunya-ch
Copy link
Contributor

@sunya-ch sunya-ch commented Sep 17, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fixes the issue when enabling both DRAPartitionableDevices and ConsumableCapacity.

This PR updates the present allow-multiple-allocations-with-partitionable-device test case to properly confirm that setting the allowMultipleAllocations will not break the current functionality of PartitionableDevices.

Additionally, it adds a new test case consumable-capacity-with-partitionable-device-multiple-capacity-pools which can confirm this bug fix.

Simplified test case

counterSet0: 4

device1 (allowMultipleAllocations): consume 2 from counterSet0
device2 (allowMultipleAllocations): consume 4 from counterSet0
device3 (allowMultipleAllocations): consume 2 from counterSet0

req0: request capacity 1
req2: request capacity 2
req1: (subrequest prioritize 4 > 2, request capacity 1)

Expect

  • req0 can get device 1
  • req2 can get device 3 (device 1 has no enough capacity left, device 2 is skipped since there is not enough left in counterSet0)
  • req1 cannot get higher-priority of device 2 due to the counterSet limit but can get the remaining capacity in device 1

Which issue(s) this PR is related to:

Fixes #134100

Special notes for your reviewer:

Will rebase and left only one last commit after #133706 merge

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 17, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Sep 17, 2025
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. wg/device-management Categorizes an issue or PR as relevant to WG Device Management. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 17, 2025
@sunya-ch sunya-ch marked this pull request as draft September 17, 2025 06:51
@bart0sh bart0sh moved this from Triage to Work in progress in SIG Node: code and documentation PRs Sep 18, 2025
@pohly pohly moved this from 🆕 New to 🏗 In progress in Dynamic Resource Allocation Sep 22, 2025
… previously consumed the counterSet

Signed-off-by: Sunyanan Choochotkaew <[email protected]>
@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Oct 10, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sunya-ch
Once this PR has been reviewed and has the lgtm label, please assign thockin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.

Projects

Status: 🏗 In progress

Development

Successfully merging this pull request may close these issues.

DRA consumable capacity failed to allocate the same device once device consumes counterSet

2 participants