Skip to content

Upgrade the build image from 1.12.5 to 1.12.7 #4907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 29, 2019
Merged

Upgrade the build image from 1.12.5 to 1.12.7 #4907

merged 3 commits into from
Jul 29, 2019

Conversation

afbjorklund
Copy link
Collaborator

For #4895

@afbjorklund afbjorklund requested a review from medyagh July 29, 2019 10:47
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 29, 2019
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 29, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2019
@afbjorklund
Copy link
Collaborator Author

afbjorklund commented Jul 29, 2019 •
edited
Loading

Seems that we are leaking translation support into the drivers now... ☹️

# k8s.io/minikube/pkg/minikube/translate
pkg/minikube/translate/translate.go:77:12: undefined: Asset

Opened #4909

josedonizetti
josedonizetti approved these changes Jul 29, 2019
View reviewed changes
Copy link
Member

@josedonizetti josedonizetti left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested both MINIKUBE_BUILD_IN_DOCKER=y make ... and make .... OSX and Linux.

@tstromberg tstromberg merged commit 61e1261 into kubernetes:master Jul 29, 2019
@afbjorklund afbjorklund deleted the kube-cross branch July 30, 2019 07:48
@warmchang
Copy link
Contributor

Now should update to go 1.12.8?

xref:
https://github.com/kubernetes/kubernetes/blob/master/build/build-image/cross/Dockerfile#L18
https://github.com/docker-library/golang/blob/master/1.12/stretch/Dockerfile#L12

@afbjorklund
Copy link
Collaborator Author

Now should update to go 1.12.8?

Should be done in #5087

@medyagh: note that this also updates the underlying distro from "stretch" to "buster"

k8s.gcr.io/kube-cross:v1.12.8-1

FROM golang:1.12.8

https://hub.docker.com/_/golang
1.12.8, 1.12, 1, latest:
1.12.8-buster

https://github.com/docker-library/golang/blob/master/1.12/buster/Dockerfile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josedonizetti josedonizetti josedonizetti approved these changes

@medyagh medyagh medyagh approved these changes

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@afbjorklund @k8s-ci-robot @warmchang @josedonizetti @medyagh @tstromberg