Skip to content

Update dependencies in Godep for #275 #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 4, 2019
Merged

Update dependencies in Godep for #275 #286

merged 5 commits into from
Jun 4, 2019

Conversation

xueweiz
Copy link
Contributor

@xueweiz xueweiz commented Jun 3, 2019

As part of #284 , in #275 , we adds in new dependencies on gopsutil and OpenCensus.
This PR updates Godep so that NPD can build correctly.

I separated these code out from #275 , so that #275 can focus on real code changes, rather than dependency management.

Xuewei Zhang added 5 commits June 3, 2019 15:04
Comment changes in Godeps
adc6c0d 
This change is purely git tag changes, with no real change.

This change is generated via below commands in an empty go1.9
environment:
mkdir -p $GOPATH/src/k8s.io
cd $GOPATH/src/k8s.io && go get k8s.io/node-problem-detector
cd $GOPATH/src/k8s.io/node-problem-detector
godep restore ./...
godep save ./...
Add OpenCensus in Godep
3c0fe22 
This is generated using below commands:
go get -u -v go.opencensus.io/...
go get -u -v contrib.go.opencensus.io/exporter/prometheus
godep update ./...
godep save ./...
Update github.com/golang/protobuf/proto
5fe3709 
OpenCensus requires a newer github.com/golang/protobuf/proto.

This is done via:
go get -u github.com/golang/protobuf/proto
godep update ./...
godep save ./...
Add github.com/shirou/gopsutil/disk in Godep
d744b1c
Update golang.org/x/sys/unix
ff8025a 
Newer version of golang.org/x/sys/unix is required by github.com/shirou/gopsutil
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 3, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @xueweiz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 3, 2019
@xueweiz
Copy link
Contributor Author

xueweiz commented Jun 3, 2019

/assign @wangzhen127

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 3, 2019
@xueweiz xueweiz mentioned this pull request Jun 3, 2019
Merged
3 tasks
@wangzhen127
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 3, 2019
@xueweiz xueweiz mentioned this pull request Jun 4, 2019
Closed
7 tasks
@andyxning
Copy link
Member

/lgtm
/approve

@xueweiz You need to force push in #275.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyxning, xueweiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit 520b650 into kubernetes:master Jun 4, 2019
@xueweiz xueweiz mentioned this pull request Jun 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyxning andyxning Awaiting requested review from andyxning

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

Assignees

@wangzhen127 wangzhen127

@andyxning andyxning

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xueweiz @k8s-ci-robot @wangzhen127 @andyxning