Add two dependencies #302

xueweiz · 2019-06-27T19:34:46Z

This PR introduced two dependencies:

github.com/shirou/gopsutil/host
github.com/cobaugh/osrelease

They are needed in #303. I separated out the vendor changes, because they are larger while easier to
review.

They are done via:

GO111MODULE=on go get github.com/shirou/gopsutil/host
GO111MODULE=on go mod vendor
GO111MODULE=on go get github.com/cobaugh/osrelease
GO111MODULE=on go mod vendor

k8s-ci-robot · 2019-06-27T19:34:54Z

Hi @xueweiz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

xueweiz · 2019-06-27T19:35:08Z

/assign @wangzhen127

wangzhen127 · 2019-06-27T19:57:11Z

/ok-to-test

wangzhen127 · 2019-06-27T20:01:24Z

What functions do you plan to use from this library? I am trying to see what is being used by kubernetes community for similar functionalities and check if there is any best practice.

xueweiz · 2019-06-27T20:17:24Z

What functions do you plan to use from this library?

They haven't been finalized yet. But here is the list of functions I'm experimenting with:

For host monitoring:
https://godoc.org/github.com/shirou/gopsutil/host#KernelVersion
https://godoc.org/github.com/shirou/gopsutil/host#Uptime

Thanks for check with what k8s community has right now! And please let me know if you have any findings :)

xueweiz · 2019-06-27T20:25:28Z

btw this is still the gopsutil library (#289) we used for retrieving disk stats in #275

The library is composed of a few components (host, process, mem, disk, etc...). I only included disk last time.
Actually, maybe I should just include all of them in the vendor. Because we will probably need them in near future anyways. WDYT?

This is needed to measure system uptime and kernel version. This done via: GO111MODULE=on go get github.com/shirou/gopsutil/host GO111MODULE=on go mod vendor

This is needed for parsing /etc/os-release file. This done via: GO111MODULE=on go get github.com/cobaugh/osrelease GO111MODULE=on go mod vendor

wangzhen127 · 2019-06-28T16:47:33Z

Actually, maybe I should just include all of them in the vendor. Because we will probably need them in near future anyways. WDYT?

Sounds good to me.

I didn't find any similar usage in k8s. Let's use this for now. We can change to other stuff later if there is any better library.

xueweiz · 2019-06-28T20:08:23Z

Actually, maybe I should just include all of them in the vendor

Seems this is not very straight forward. When I do go mod vendor, it automatically drops all unused modules.

Let's just import what we use right now, and import the new ones when we need them.

wangzhen127 · 2019-07-02T15:00:35Z

/lgtm
/approve

k8s-ci-robot · 2019-07-02T15:00:49Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wangzhen127, xueweiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [wangzhen127]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

wangzhen127 · 2019-07-02T16:21:03Z

/hold
Are you going to merge this first and then the other one?

xueweiz · 2019-07-02T20:02:00Z

Yes, I plan to merge this first. Then rebase #303 , then merge #303

xueweiz · 2019-07-02T20:04:47Z

/retest

k8s-ci-robot · 2019-07-02T20:07:03Z

@xueweiz: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-npd-e2e-kubernetes-gce-ubuntu-custom-flags	`b517ea0`	link	`/test pull-npd-e2e-kubernetes-gce-ubuntu-custom-flags`
pull-npd-e2e-kubernetes-gce-gci-custom-flags	`b517ea0`	link	`/test pull-npd-e2e-kubernetes-gce-gci-custom-flags`
pull-npd-e2e-kubernetes-gce-gci	`b517ea0`	link	`/test pull-npd-e2e-kubernetes-gce-gci`
pull-npd-e2e-kubernetes-gce-ubuntu	`b517ea0`	link	`/test pull-npd-e2e-kubernetes-gce-ubuntu`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2019-07-02T20:07:04Z

@xueweiz: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-npd-e2e-kubernetes-gce-ubuntu	`b517ea0`	link	`/test pull-npd-e2e-kubernetes-gce-ubuntu`
pull-npd-e2e-kubernetes-gce-gci-custom-flags	`b517ea0`	link	`/test pull-npd-e2e-kubernetes-gce-gci-custom-flags`
pull-npd-e2e-kubernetes-gce-gci	`b517ea0`	link	`/test pull-npd-e2e-kubernetes-gce-gci`
pull-npd-e2e-kubernetes-gce-ubuntu-custom-flags	`b517ea0`	link	`/test pull-npd-e2e-kubernetes-gce-ubuntu-custom-flags`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2019-07-02T20:07:04Z

@xueweiz: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-npd-e2e-kubernetes-gce-ubuntu	`b517ea0`	link	`/test pull-npd-e2e-kubernetes-gce-ubuntu`
pull-npd-e2e-kubernetes-gce-ubuntu-custom-flags	`b517ea0`	link	`/test pull-npd-e2e-kubernetes-gce-ubuntu-custom-flags`
pull-npd-e2e-kubernetes-gce-gci	`b517ea0`	link	`/test pull-npd-e2e-kubernetes-gce-gci`
pull-npd-e2e-kubernetes-gce-gci-custom-flags	`b517ea0`	link	`/test pull-npd-e2e-kubernetes-gce-gci-custom-flags`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2019-07-02T20:07:04Z

@xueweiz: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-npd-e2e-kubernetes-gce-ubuntu	`b517ea0`	link	`/test pull-npd-e2e-kubernetes-gce-ubuntu`
pull-npd-e2e-kubernetes-gce-ubuntu-custom-flags	`b517ea0`	link	`/test pull-npd-e2e-kubernetes-gce-ubuntu-custom-flags`
pull-npd-e2e-kubernetes-gce-gci-custom-flags	`b517ea0`	link	`/test pull-npd-e2e-kubernetes-gce-gci-custom-flags`
pull-npd-e2e-kubernetes-gce-gci	`b517ea0`	link	`/test pull-npd-e2e-kubernetes-gce-gci`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

xueweiz · 2019-07-02T22:56:39Z

For convenience, let's just submit the vendor changes as part of #303
I'll drop this PR.

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 27, 2019

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 27, 2019

k8s-ci-robot requested review from dchen1107 and wangzhen127 June 27, 2019 19:34

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 27, 2019

k8s-ci-robot assigned wangzhen127 Jun 27, 2019

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 27, 2019

xueweiz mentioned this pull request Jun 27, 2019

Implement host collector as part of system-stats-monitor #303

Merged

xueweiz force-pushed the vendor branch from 7fb853c to 8d500ae Compare June 27, 2019 23:50

Xuewei Zhang added 2 commits June 27, 2019 16:50

Add github.com/shirou/gopsutil/host to vendor

5d73e8a

This is needed to measure system uptime and kernel version. This done via: GO111MODULE=on go get github.com/shirou/gopsutil/host GO111MODULE=on go mod vendor

Add github.com/cobaugh/osrelease as dependency

b517ea0

This is needed for parsing /etc/os-release file. This done via: GO111MODULE=on go get github.com/cobaugh/osrelease GO111MODULE=on go mod vendor

xueweiz force-pushed the vendor branch from 8d500ae to b517ea0 Compare June 27, 2019 23:50

xueweiz changed the title ~~Add github.com/shirou/gopsutil/host to vendor~~ Add two dependencies Jun 27, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2019

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2019

xueweiz closed this Jul 2, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add two dependencies #302

Add two dependencies #302

xueweiz commented Jun 27, 2019 •

edited

Loading

k8s-ci-robot commented Jun 27, 2019

xueweiz commented Jun 27, 2019

wangzhen127 commented Jun 27, 2019

wangzhen127 commented Jun 27, 2019

xueweiz commented Jun 27, 2019 •

edited

Loading

xueweiz commented Jun 27, 2019

wangzhen127 commented Jun 28, 2019

xueweiz commented Jun 28, 2019

wangzhen127 commented Jul 2, 2019

k8s-ci-robot commented Jul 2, 2019

wangzhen127 commented Jul 2, 2019

xueweiz commented Jul 2, 2019

xueweiz commented Jul 2, 2019

k8s-ci-robot commented Jul 2, 2019

k8s-ci-robot commented Jul 2, 2019

k8s-ci-robot commented Jul 2, 2019

k8s-ci-robot commented Jul 2, 2019

xueweiz commented Jul 2, 2019

Add two dependencies #302

Add two dependencies #302

Conversation

xueweiz commented Jun 27, 2019 • edited Loading

k8s-ci-robot commented Jun 27, 2019

xueweiz commented Jun 27, 2019

wangzhen127 commented Jun 27, 2019

wangzhen127 commented Jun 27, 2019

xueweiz commented Jun 27, 2019 • edited Loading

xueweiz commented Jun 27, 2019

wangzhen127 commented Jun 28, 2019

xueweiz commented Jun 28, 2019

wangzhen127 commented Jul 2, 2019

k8s-ci-robot commented Jul 2, 2019

wangzhen127 commented Jul 2, 2019

xueweiz commented Jul 2, 2019

xueweiz commented Jul 2, 2019

k8s-ci-robot commented Jul 2, 2019

k8s-ci-robot commented Jul 2, 2019

k8s-ci-robot commented Jul 2, 2019

k8s-ci-robot commented Jul 2, 2019

xueweiz commented Jul 2, 2019

xueweiz commented Jun 27, 2019 •

edited

Loading

xueweiz commented Jun 27, 2019 •

edited

Loading