Skip to content

Introduce Windows build of Node Problem Detector #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Introduce Windows build of Node Problem Detector #502

merged 1 commit into from
Dec 8, 2020

Conversation

jeremyje
Copy link
Contributor

@jeremyje jeremyje commented Dec 6, 2020

Changes to the NPD codebase to split out Linux and Windows dependencies.
Simply allows Windows binary outputs, they do not function yet.
This change also introduces new build targets that are easier to allow for different OS/arch versions.
Old targets are kept to remain compatible with the current CI.

First change for #461.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 6, 2020
@xueweiz
Copy link
Contributor

xueweiz commented Dec 8, 2020

Very clean change! Thanks @jeremyje !
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 8, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeremyje, xueweiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xueweiz
Copy link
Contributor

xueweiz commented Dec 8, 2020

The test failures seems more like a bug in the test infra:

Ran 1 of 5667 Specs in 270.332 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 5666 Skipped
Ginkgo ran 1 suite in 4m39.791266223s
...
2020/12/08 02:02:05 e2e.go:544: Dumping logs locally to: /logs/artifacts
2020/12/08 02:02:05 process.go:153: Running: ./cluster/log-dump/log-dump.sh /logs/artifacts
Checking for custom logdump instances, if any
k/k version of the log-dump.sh script is deprecated!
Please migrate your test job to use test-infra's repo version of log-dump.sh!
Migration steps can be found in the readme file.
...
scp: /var/log/cluster-autoscaler.log*: No such file or directory
scp: /var/log/konnectivity-server.log*: No such file or directory
scp: /var/log/fluentd.log*: No such file or directory
scp: /var/log/kubelet.cov*: No such file or directory
scp: /var/log/startupscript.log*: No such file or directory
ERROR: (gcloud.compute.scp) [/usr/bin/scp] exited with return code [1].

@jeremyje
Copy link
Contributor Author

jeremyje commented Dec 8, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 8f2a94f into kubernetes:master Dec 8, 2020
@jeremyje jeremyje deleted the windows branch December 8, 2020 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants