Skip to content

Allow skipping condition during customplugin initialization #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2022
Merged

Allow skipping condition during customplugin initialization #646

merged 1 commit into from
Jul 27, 2022

Conversation

notchairmk
Copy link
Contributor

Implements Option A from #645

Allows user to specify skip_initial_status in plugin configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 13, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 13, 2022 •
edited
Loading

@notchairmk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-npd-e2e-kubernetes-gce-gci-custom-flags faaedb6 link true /test pull-npd-e2e-kubernetes-gce-gci-custom-flags
pull-npd-e2e-kubernetes-gce-ubuntu faaedb6 link true /test pull-npd-e2e-kubernetes-gce-ubuntu
pull-npd-e2e-kubernetes-gce-gci faaedb6 link true /test pull-npd-e2e-kubernetes-gce-gci
pull-npd-e2e-kubernetes-gce-ubuntu-custom-flags faaedb6 link true /test pull-npd-e2e-kubernetes-gce-ubuntu-custom-flags

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@notchairmk
Copy link
Contributor Author

/retest

@notchairmk notchairmk force-pushed the notchairmk/custom-skip-initial branch from faaedb6 to b9c9cac Compare April 26, 2022 17:10
@notchairmk notchairmk force-pushed the notchairmk/custom-skip-initial branch from b9c9cac to 9344c93 Compare April 26, 2022 17:12
@notchairmk
Copy link
Contributor Author

/retest

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 26, 2022
@Random-Liu
Copy link
Member

This fix and reasoning make sense to me.

@Random-Liu
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: notchairmk, Random-Liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2022
@k8s-ci-robot k8s-ci-robot merged commit 341af62 into kubernetes:master Jul 27, 2022
@notchairmk notchairmk mentioned this pull request Aug 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vteratipally vteratipally Awaiting requested review from vteratipally

@wangzhen127 wangzhen127 Awaiting requested review from wangzhen127

Assignees

@Random-Liu Random-Liu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@notchairmk @k8s-ci-robot @k8s-triage-robot @Random-Liu