Support multiple reasons per condition for CustomPluginMonitor

[jason1028kr]

Issue: #664

Original issue that describes current behavior: #566

• plugin uses intervalEndChan to signal interval end (all plugins ran for the interval).

• custom_plugin_monitor.go's monitorLoop() function now gathers result until it receives interval end signal. Only then, it calls new generateStatus(results []cpmtypes.Result) to create one event for each condition.

• unit test added

• local testing output on a test cluster below

New behaviors:

Node describe output:

  Normal  TestIsIntentionallyFailing  6s (x57 over 56m)     test-custom-plugin-monitor  Node condition TestConditionHasProblem is now: True, reason: TestIsIntentionallyFailing

NPD pod logs:

I0407 00:18:53.174047       1 custom_plugin_monitor.go:361] Initialize condition generated: [{Type:TestConditionHasProblem Status:False Transition:2022-04-07 00:18:53.174038607 +0000 UTC m=+4.099922893 Reason:TestIsOK Message:test condition is OK}]
I0407 00:19:53.173518       1 custom_plugin_monitor.go:340] New status generated: &{Source:test-custom-plugin-monitor Events:[{Severity:info Timestamp:2022-04-07 00:19:53.075037997 +0000 UTC m=+64.000922383 Reason:TestIsIntentionallyFailing Message:Node condition TestConditionHasProblem is now: True, reason: TestIsIntentionallyFailing}] Conditions:[{Type:TestConditionHasProblem Status:True Transition:2022-04-07 00:19:53.075037997 +0000 UTC m=+64.000922383 Reason:TestIsIntentionallyFailing Message:}]}
I0407 00:20:52.977094       1 custom_plugin_monitor.go:340] New status generated: &{Source:test-custom-plugin-monitor Events:[{Severity:info Timestamp:2022-04-07 00:20:52.977058649 +0000 UTC m=+123.902942935 Reason:TestIsIntentionallyFailing Message:Node condition TestConditionHasProblem is now: True, reason: TestIsIntentionallyFailing}] Conditions:[{Type:TestConditionHasProblem Status:True Transition:2022-04-07 00:19:53.075037997 +0000 UTC m=+64.000922383 Reason:TestIsIntentionallyFailing Message:}]}
I0407 00:21:53.075186       1 custom_plugin_monitor.go:340] New status generated: &{Source:test-custom-plugin-monitor Events:[{Severity:info Timestamp:2022-04-07 00:21:53.075120494 +0000 UTC m=+184.001004780 Reason:TestIsIntentionallyFailing Message:Node condition TestConditionHasProblem is now: True, reason: TestIsIntentionallyFailing}] Conditions:[{Type:TestConditionHasProblem Status:True Transition:2022-04-07 00:19:53.075037997 +0000 UTC m=+64.000922383 Reason:TestIsIntentionallyFailing Message:}]}
I0407 00:22:53.074590       1 custom_plugin_monitor.go:340] New status generated: &{Source:test-custom-plugin-monitor Events:[{Severity:info Timestamp:2022-04-07 00:22:53.074550383 +0000 UTC m=+244.000434769 Reason:TestIsIntentionallyFailing Message:Node condition TestConditionHasProblem is now: True, reason: TestIsIntentionallyFailing}] Conditions:[{Type:TestConditionHasProblem Status:True Transition:2022-04-07 00:19:53.075037997 +0000 UTC m=+64.000922383 Reason:TestIsIntentionallyFailing Message:}]}

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: jason1028kr / name: Jason Jung (10cf230, 2ec15b6, cd8089e, 16f2f9a, 3e13109, c052095, 87795bf, fae5ef9, bd91955, 5eff954)

[k8s-ci-robot]

Welcome @jason1028kr!

It looks like this is your first PR to kubernetes/node-problem-detector 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/node-problem-detector has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @jason1028kr. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vteratipally]

thank you for the PR. Could you please squash all commits into one.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: jason1028kr / name: Jason Jung (3702270)

[jason1028kr]

thank you for the PR. Could you please squash all commits into one.

Thank you! I've squashed them to one.

[k8s-ci-robot]

@jason1028kr: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jason1028kr]

/assign @dchen1107

[vteratipally]

/ok-to-test

[jason1028kr]

@vteratipally Does this look good to go ahead?

[juan-lee]

@vteratipally could you have another look please?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jason1028kr
To complete the pull request process, please ask for approval from dchen1107 after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[juan-lee]

@dchen1107 would you be able to help @jason1028kr with a review on his PR?

[vteratipally]

Overall pr looks good. I will have to do a manual testing

[vteratipally]

Random-Liu could you please take a look at the pr

[jason1028kr]

Hello @Random-Liu! Would you mind taking a look at this pr?

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[vteratipally]

/remove-lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle rotten
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.