Skip to content

Add DamianSawicki and kl52752 as ingress-gce maintainers #5840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add DamianSawicki and kl52752 as ingress-gce maintainers #5840

wants to merge 2 commits into from
+41 −23

Conversation

swetharepakula
Copy link
Member

/assign @bowei
/assign @mmamczur

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/github-management Issues or PRs related to GitHub Management subproject labels Sep 16, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 16, 2025
@bowei
Copy link
Member

bowei commented Sep 16, 2025

/lgtm

but we should really move these owner entries into a different more focused owner directory and avoid having this in the main file

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 16, 2025
@mmamczur
Copy link
Contributor

we moved cloud-provider-gcp setup to https://github.com/kubernetes/org/tree/main/config/kubernetes/provider-gcp
so maybe something similar or even use that directory?

/lgtm

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 23, 2025
@mmamczur
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2025
@swetharepakula
Copy link
Member Author

/assign @cblecker

@cblecker
Copy link
Member

/hold
Oversight for this repo is under sig-network, so please move it under that directory if you are planning on moving it.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2025
@swetharepakula
Create team directory for ingress-gce
be4c245 
This makes the ingress-gce maintainers the OWNERS for the directory. All
other permissions for the kubernetes/ingress-gce repository stays the
same.

ingress-gce is still part of sig/network
@swetharepakula
Add DamianSawicki and kl52752 as ingress-gce maintainers
de35c7e
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Sep 30, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: swetharepakula
Once this PR has been reviewed and has the lgtm label, please ask for approval from cblecker. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@swetharepakula
Copy link
Member Author

I updated the PR by moving the new ingress-gce directory into the sig-network directory

@swetharepakula
Copy link
Member Author

@cblecker, any update? Is that change match with what you were suggesting? Or should I keep it in the main config file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonbraganza jasonbraganza Awaiting requested review from jasonbraganza

@MadhavJivrajani MadhavJivrajani Awaiting requested review from MadhavJivrajani

Assignees

@bowei bowei

@cblecker cblecker

@mmamczur mmamczur

Labels
area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@swetharepakula @bowei @mmamczur @cblecker @k8s-ci-robot