Skip to content

Warning about deprecated linter option #2801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mboersma opened this issue Aug 1, 2024 · 1 comment · Fixed by #2807
Closed

Warning about deprecated linter option #2801

mboersma opened this issue Aug 1, 2024 · 1 comment · Fixed by #2807
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@mboersma
Copy link
Contributor

mboersma commented Aug 1, 2024

What happened:

When running the pull-tests-verify-lint job, a warning is consistently printed:

golangci-lint run ./...
level=warning msg="[config_reader] The configuration option `linters.errcheck.ignore` is deprecated, please use `linters.errcheck.exclude-functions`."

What you expected to happen:

No warnings are printed because perf-tests is using current configuration options for golangci-lint. (Or maybe the tool itself needs updating?)

How to reproduce it (as minimally and precisely as possible):

I can't reproduce this locally, which is odd.

% golangci-lint version
golangci-lint has version 1.59.1 built with go1.22.3 from 1a55854a on 2024-06-09T18:08:33Z
% cd clusterloader2
% golangci-lint run --config=../.golangci.yml ./... 
% echo $?
0

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • OS (e.g: cat /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Network plugin and version (if this is a network-related bug):
  • Others:
@mboersma mboersma added the kind/bug Categorizes issue or PR as related to a bug. label Aug 1, 2024
@mboersma
Copy link
Contributor Author

mboersma commented Aug 7, 2024

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant