Skip to content

Add workaround for errcheck linter warning #2807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

mboersma
Copy link
Contributor

@mboersma mboersma commented Aug 7, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates the golangci-lint configuration to silence an errcheck linter warning.

Which issue(s) this PR fixes:

Fixes #2801

Special notes for your reviewer:

See golangci/golangci-lint#4733

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 7, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 7, 2024
@mboersma
Copy link
Contributor Author

mboersma commented Aug 7, 2024

Before:

+ golangci-lint version
golangci-lint has version 1.58.2 built with go1.22.3 from 8c4cfb61 on 2024-05-19T18:08:33Z
+ for mod in $MODULE_BASED
+ cd ./benchmark
+ GO111MODULE=on
+ golangci-lint run ./...
level=warning msg="[config_reader] The configuration option `linters.errcheck.ignore` is deprecated, please use `linters.errcheck.exclude-functions`."
+ for mod in $MODULE_BASED
+ cd ./clusterloader2
+ GO111MODULE=on
+ golangci-lint run ./...
level=warning msg="[config_reader] The configuration option `linters.errcheck.ignore` is deprecated, please use `linters.errcheck.exclude-functions`."
+ for mod in $MODULE_BASED
+ cd ./dns/dnsperfgo
+ GO111MODULE=on
+ golangci-lint run ./...
level=warning msg="[config_reader] The configuration option `linters.errcheck.ignore` is deprecated, please use `linters.errcheck.exclude-functions`."
...

After:

+ golangci-lint version
golangci-lint has version 1.58.2 built with go1.22.3 from 8c4cfb61 on 2024-05-19T18:08:33Z
+ for mod in $MODULE_BASED
+ cd ./benchmark
+ GO111MODULE=on
+ golangci-lint run ./...
+ for mod in $MODULE_BASED
+ cd ./clusterloader2
+ GO111MODULE=on
+ golangci-lint run ./...
+ for mod in $MODULE_BASED
+ cd ./dns/dnsperfgo
+ GO111MODULE=on
+ golangci-lint run ./...
+ for mod in $MODULE_BASED
+ cd ./dns/jsonify
...

@wojtek-t
Copy link
Member

wojtek-t commented Aug 7, 2024

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2024
@k8s-ci-robot k8s-ci-robot merged commit e924883 into kubernetes:master Aug 7, 2024
5 checks passed
@mboersma mboersma deleted the update-linter-config branch August 7, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning about deprecated linter option
3 participants