Add HTML output to krel changelog
#1005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
16 tasks
k8s-ci-robot
added
area/release-eng
|
@saschagrunert -- Needs rebase. |
k8s-ci-robot
added
needs-rebase
|
Rebased on top of the latest master. 👍 |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
approved
|
@saschagrunert -- Needs rebase |
k8s-ci-robot
added
the
needs-rebase
|
@saschagrunert - needs rebase (just messing with you 😂) |
We now render the HTML from the markdown via blackfriday and output it side-by-side to the changelog file. The HTML file will be later used only inside the release announcement mail. Signed-off-by: Sascha Grunert <[email protected]>
k8s-ci-robot
removed
lgtm
|
Rebased on top of the latest master to resolve the conflicts 😇 |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, justaugustus, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added a commit
that referenced
this pull request
Jul 31, 2020
gcbmgr: add releases numbers tags to the cloudbuild
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now render the HTML from the markdown via blackfriday and output it
side-by-side to the changelog file. The HTML file will be later used
only inside the release announcement mail.