Fix golangci-lint CI

[saschagrunert]

It looks like we're hitting the same issue as described in:
golangci/golangci-lint#827

As a workaround, we now disable the unused linter for now.

[cpanato]

/lgtm

[hoegaarden]

The issue talks about the error:

WARN [runner] Can't run linter goanalysis_metalinter: fact_purity: failed prerequisites: [email protected]/cozy/cozy-stack/model/instance/lifecycle [github.com/cozy/cozy-stack/model/app.test]

@saschagrunert How did you map that to the unused linter? Considering we get different errors for different PRs, I am not sure if there isn't a bigger problem somewhere and we are just trying random things? Or aren't those issues not related? I have no idea about golangci-lint. Recently it just annoys me most of the time! ;)

Anyhow, happy to merge if you think that's the appropriate fix.

---

#1040
https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/release/1040/pull-release-test/1221841425608478720

level=warning msg="[runner] Can't run linter goanalysis_metalinter: fact_purity: failed prerequisites: [email protected]/release/pkg/notes/notesfakes [k8s.io/release/pkg/notes.test]"
level=error msg="Running error: fact_purity: failed prerequisites: [email protected]/release/pkg/notes/notesfakes [k8s.io/release/pkg/notes.test]"

#1044
https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/release/1044/pull-release-test/1222146917287333888

level=warning msg="[runner] Can't run linter goanalysis_metalinter: ctrlflow: failed prerequisites: [email protected]/release/pkg/notes/notesfakes [k8s.io/release/pkg/notes.test]"
level=error msg="Running error: ctrlflow: failed prerequisites: [email protected]/release/pkg/notes/notesfakes [k8s.io/release/pkg/notes.test]"

#1043
https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/release/1043/pull-release-test/1222120743693717504

level=warning msg="[runner] Can't run linter goanalysis_metalinter: ctrlflow: failed prerequisites: [email protected]/release/pkg/notes/notesfakes [k8s.io/release/pkg/notes.test]"
level=error msg="Running error: ctrlflow: failed prerequisites: [email protected]/release/pkg/notes/notesfakes [k8s.io/release/pkg/notes.test]"

[hasheddan]

It looks like a potential fix may be in place soon: golangci/golangci-lint#944

[saschagrunert]

I basically tested it within the container image and now the issue seems gone. I did not dive into the issue that deep but I think since there are already fixes incoming we could live with that workaround here 🤷‍♂️ WDYT?

[justaugustus]

Let's keep an eye on those issues/PRs and pull in the fix when it's ready.
/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [justaugustus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ernado]

Referenced issue should be fixed in latest golangci-lint version, please CC me directly if it will break again.

[hasheddan]

@ernado awesome! Thanks for following up here