Skip to content

Add krel changelog integration tests #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2020
Merged

Add krel changelog integration tests #1068

merged 1 commit into from
Mar 5, 2020

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Feb 6, 2020 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Added first krel changelog integration test cases. This also refactors the shared test-methods around the SUT (system under test) into a dedicated sut_test.go file.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

None

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Feb 6, 2020
@saschagrunert saschagrunert changed the title Add first patch release changelog integration test Add first patch release changelog integration tests Feb 6, 2020
@saschagrunert saschagrunert mentioned this pull request Feb 6, 2020
Closed
@saschagrunert saschagrunert changed the title Add first patch release changelog integration tests Add krel changelog integration tests Feb 6, 2020
@saschagrunert
Copy link
Member Author

/test pull-release-test

@saschagrunert
Copy link
Member Author

Ready for review ✔️

@saschagrunert saschagrunert mentioned this pull request Feb 10, 2020
Closed
16 tasks
@justaugustus
Copy link
Member

Leaving others to take the review on this:
/assign @hasheddan @hoegaarden @cpanato
/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from justaugustus February 12, 2020 02:48
@saschagrunert saschagrunert mentioned this pull request Feb 19, 2020
Merged
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. labels Feb 19, 2020
@saschagrunert
Copy link
Member Author

Waiting for #1068 to rebase

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 24, 2020
@saschagrunert
Copy link
Member Author

Rebased on top of the latest master branch to resolve conflicts. I also refactored code used in multiple locations into sut_test.go

@saschagrunert
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 27, 2020
@saschagrunert
Copy link
Member Author

Rebased on top of the latest master branch

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2020
@saschagrunert
Copy link
Member Author

@justaugustus do we want to move forward with this one?

@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 4, 2020
hasheddan
hasheddan approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hasheddan
Copy link
Contributor

Do we need to bump timeout on pull-release-test?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2020
@saschagrunert
Copy link
Member Author

Do we need to bump timeout on pull-release-test?

No the test was failing after prow's rebase. Fixed that in rebased on top of the latest master branch

cpanato
cpanato approved these changes Mar 5, 2020
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2020
@justaugustus
Copy link
Member

/retest

@saschagrunert
Copy link
Member Author

saschagrunert commented Mar 5, 2020 •
edited
Loading

There were tests whose specified size is too big. 🤔

Does the bazel sandbox some size restrictions?

@saschagrunert
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2020
@saschagrunert
Add krel changelog integration tests
0ef23d3 
This also refactors the shared test-methods around the SUT (system under
test) into a dedicated `sut_test.go` file.

Signed-off-by: Sascha Grunert <[email protected]>
@saschagrunert
Copy link
Member Author

saschagrunert commented Mar 5, 2020 •
edited
Loading

Will now increase the test timeout via .bazelrc.

@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, hasheddan, justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 078b9ab into kubernetes:master Mar 5, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 5, 2020
@saschagrunert saschagrunert deleted the changelog-integration-2 branch March 5, 2020 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

+1 more reviewer

@hasheddan hasheddan hasheddan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@justaugustus justaugustus

@hoegaarden hoegaarden

@cpanato cpanato

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
6 participants
@saschagrunert @justaugustus @hasheddan @k8s-ci-robot @cpanato @hoegaarden