Skip to content

Make SIG list more compact #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2020
Merged

Make SIG list more compact #1069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/notes/document.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ func prettySIG(sig string) string {
return strings.Join(parts, " ")
}

func prettifySigList(sigs []string) string {
func prettifySIGList(sigs []string) string {
sigList := ""

// sort the list so that any group of SIGs with the same content gives us the
Expand All @@ -219,9 +219,9 @@ func prettifySigList(sigs []string) string {
if i == 0 {
sigList = fmt.Sprintf("SIG %s", prettySIG(sig))
} else if i == len(sigs)-1 {
sigList = fmt.Sprintf("%s, and SIG %s", sigList, prettySIG(sig))
sigList = fmt.Sprintf("%s and %s", sigList, prettySIG(sig))
} else {
sigList = fmt.Sprintf("%s, SIG %s", sigList, prettySIG(sig))
sigList = fmt.Sprintf("%s, %s", sigList, prettySIG(sig))
}
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/notes/notes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ func (g *Gatherer) ReleaseNoteFromCommit(result *Result, relVer string) (*Releas
g.options.GithubOrg, g.options.GithubRepo, pr.GetNumber(),
)
isFeature := HasString(LabelsWithPrefix(pr, "kind"), "feature")
noteSuffix := prettifySigList(LabelsWithPrefix(pr, "sig"))
noteSuffix := prettifySIGList(LabelsWithPrefix(pr, "sig"))

isDuplicateSIG := false
if len(LabelsWithPrefix(pr, "sig")) > 1 {
Expand Down