Skip to content

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Feb 7, 2020

What type of PR is this?

/kind feature

What this PR does / why we need it:

To be more close to the final release notes template, we should show the
notes with action required in a dedicated section.

Which issue(s) this PR fixes:

Fixes kubernetes/sig-release#882

Special notes for your reviewer:

Demo:

> go run cmd/release-notes/main.go --start-sha 566484366e2701b7bbd9414ccfb967bda13d75c9 --end-sha 9d0a32caf8bf9f2fdc31ee586938bdbaba64fab4 --output demo.md

Looks like this: https://gist.github.com/saschagrunert/e4ecd36ab4c2c8753cd8eb6589e37fc2

Does this PR introduce a user-facing change?:

- Add "Urgent Upgrade Notes" section to the markdown release notes based on PRs which have the `release-note-action-required` label 

To be more close to the final release notes template, we should show the
notes with action required in a dedicated section.

Signed-off-by: Sascha Grunert <[email protected]>
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 7, 2020
@k8s-ci-robot k8s-ci-robot requested review from jeefy and marpaia February 7, 2020 08:53
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Feb 7, 2020
@justaugustus
Copy link
Member

Nice catch!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Action Required Release Notes Process
3 participants