Skip to content

Conversation

puerco
Copy link
Member

@puerco puerco commented Feb 18, 2020

What type of PR is this?

/kind feature

What this PR does / why we need it:
This PR adds the flags needed to automate the creation of the release notes draft. It adds three flags: --create-draft-pr --draft-org and --draft-repo to determine the repository where the PR will be opened.

In addition, it adds a new flag: --output-dir to output a copy of the release notes.

Which issue(s) this PR fixes:

Relates to #1061

Special notes for your reviewer:

This PR is a rewrite of the code sent in PR #1102 incorporating @justaugustus suggestions

Does this PR introduce a user-facing change?:

Add --create-draft-pr --draft-org and --draft-repo flags to automate the creation of the release notes draft
Add --output-dir to output a copy of the release notes.

/cc @justaugustus @JamesLaverack

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Feb 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: puerco
To complete the pull request process, please assign saschagrunert
You can assign the PR to them by writing /assign @saschagrunert in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@puerco puerco force-pushed the draft-pr-automation branch from 2c8400a to edb33af Compare February 18, 2020 22:09
@puerco
Copy link
Member Author

puerco commented Feb 19, 2020

Cancelling this PR as we were able to salvage the original #1102

@puerco puerco closed this Feb 19, 2020
@puerco puerco deleted the draft-pr-automation branch February 26, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants