Skip to content

util/common: add new line when printing to std out to avoid messages in the same line #1125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2020
Merged

util/common: add new line when printing to std out to avoid messages in the same line #1125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/util/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,12 +200,12 @@ func Ask(question, expectedResponse string, retries int) (answer string, success
attempts := 1

if retries < 0 {
fmt.Printf("Retries was set to a number less than zero (%d). Please specify a positive number of retries or zero, if you want to ask unconditionally.", retries)
fmt.Printf("Retries was set to a number less than zero (%d). Please specify a positive number of retries or zero, if you want to ask unconditionally.\n", retries)
}

for attempts <= retries {
scanner := bufio.NewScanner(os.Stdin)
fmt.Printf("%s (%d/%d) ", question, attempts, retries)
fmt.Printf("%s (%d/%d) \n", question, attempts, retries)

scanner.Scan()
answer = scanner.Text()
Expand All @@ -214,7 +214,7 @@ func Ask(question, expectedResponse string, retries int) (answer string, success
return answer, true, nil
}

fmt.Printf("Expected '%s', but got '%s'", expectedResponse, answer)
fmt.Printf("Expected '%s', but got '%s'\n", expectedResponse, answer)

attempts++
}
Expand Down