Skip to content

Remove federation options in krel push #1128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 24, 2020
Merged

Remove federation options in krel push #1128

merged 2 commits into from
Feb 24, 2020

Conversation

hasheddan
Copy link
Contributor

Signed-off-by: hasheddan [email protected]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Removes federation references / options as follow-up to #1105

Which issue(s) this PR fixes:

Ref: #918

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Removes federation release kind option from krel push

/cc @justaugustus @saschagrunert @cpanato

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 24, 2020
justaugustus
justaugustus requested changes Feb 24, 2020
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hasheddan -- Since we no longer have multiple release kinds, can we drop release kind from the function signatures altogether?

  • release.BuiltWithBazel
  • release.ReadDockerizedVersion

plus whichever other functions have it.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2020
@justaugustus justaugustus added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Feb 24, 2020
@hasheddan
Copy link
Contributor Author

@justaugustus definitely! I had originally thought that we should keep them parameterized to make them more flexible for other potential projects, but they are already so scoped to k8s that they would have to be significantly refactored anyway :)

@hasheddan
Copy link
Contributor Author

@justaugustus should be ready here now 👍

saschagrunert
saschagrunert approved these changes Feb 24, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2020
@justaugustus
Copy link
Member

Awesome, thanks!
/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 24, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 59cf1e4 into kubernetes:master Feb 24, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus justaugustus requested changes

@saschagrunert saschagrunert saschagrunert approved these changes

@cpanato cpanato Awaiting requested review from cpanato

Assignees

@justaugustus justaugustus

@saschagrunert saschagrunert

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
4 participants
@hasheddan @justaugustus @k8s-ci-robot @saschagrunert