Skip to content

Refactor CreateDownloadsTable to use fetchMetadata #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2020
Merged

Refactor CreateDownloadsTable to use fetchMetadata #1149

merged 1 commit into from
Mar 6, 2020

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Mar 4, 2020 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Re-use the new fetchMetadata function on markdown downloads table
creation to reduce code duplication.

This also makes CreateDownloadsTable public, which will be needed for
creating the downloads table on remotely fetched release notes (new
final minor release).

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Mar 4, 2020
@k8s-ci-robot k8s-ci-robot requested review from jeefy and onyiny-ang March 4, 2020 11:29
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2020
@saschagrunert
Copy link
Member Author

/hold

Probably clashes with #1148

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2020
@saschagrunert
Copy link
Member Author

/test pull-release-test

1 similar comment
@saschagrunert
Copy link
Member Author

/test pull-release-test

@saschagrunert saschagrunert mentioned this pull request Mar 4, 2020
Closed
justaugustus
justaugustus requested changes Mar 4, 2020
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saschagrunert -- A few microscopic nits.

j0n3lson
j0n3lson reviewed Mar 4, 2020
View reviewed changes
Copy link
Contributor

@j0n3lson j0n3lson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question. Will we need createDownloadsTable() after #1019 is fixed? I planed to remove the RenderMarkdown() path in flavor of RenderMarkdownTemplate which handled download table already.

By the way @saschagrunert I found some other issues while testing and I'm adding the fixes in #1148 which will cover some refactoring, testing enhancements, and incorporate some of what you have in this PR.

@saschagrunert
Copy link
Member Author

Quick question. Will we need createDownloadsTable() after #1019 is fixed? I planed to remove the RenderMarkdown() path in flavor of RenderMarkdownTemplate which handled download table already.

Hm, yeah I'm not sure if the deprecation goes too fast. But let's move forward and hold with this PR for a while :)

@saschagrunert saschagrunert changed the title Refactor CreateDownloadsTable to use fetchMetadata WIP: Refactor CreateDownloadsTable to use fetchMetadata Mar 5, 2020
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 5, 2020
@saschagrunert
Copy link
Member Author

saschagrunert commented Mar 5, 2020 •
edited
Loading

I think we should move forward with this one. We need to be able to create the downloads table for our manually crafted release notes from SIG Release, because we can generate the downloads only during the release build process.

Implemented the review notes.

@saschagrunert saschagrunert changed the title WIP: Refactor CreateDownloadsTable to use fetchMetadata Refactor CreateDownloadsTable to use fetchMetadata Mar 5, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 5, 2020
@saschagrunert
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2020
@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2020
@saschagrunert
Refactor CreateDownloadsTable to use fetchMetadata
3360729 
Re-use the new `fetchMetadata` function on markdown downloads table
creation to reduce code duplication.

This also makes `CreateDownloadsTable` public, which will be needed for
creating the downloads table on remotely fetched release notes (new
final minor release).

Signed-off-by: Sascha Grunert <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2020
@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 23cfeb2 into kubernetes:master Mar 6, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 6, 2020
@saschagrunert saschagrunert deleted the file-reuse branch March 6, 2020 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus justaugustus requested changes

@jeefy jeefy Awaiting requested review from jeefy

@onyiny-ang onyiny-ang Awaiting requested review from onyiny-ang

+1 more reviewer

@j0n3lson j0n3lson j0n3lson left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@justaugustus justaugustus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.
4 participants
@saschagrunert @justaugustus @k8s-ci-robot @j0n3lson