-
Notifications
You must be signed in to change notification settings - Fork 519
Enable krel gcbmgr package and binary checks #1171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable krel gcbmgr package and binary checks #1171
Conversation
@saschagrunert: Adding label: Reasons for blocking this PR:[Changes to certain release tools can affect our ability to test, build, and release Kubernetes. This PR must be explicitly approved by SIG Release repo admins.] Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold until rebased on #1170 |
Ready to be rebased now that #1170 has merged. |
Rebased on top of the latest master branch |
We re-enable the commented out binary and package checks because the packages are now available in the CI. Signed-off-by: Sascha Grunert <[email protected]>
Needs #1206 |
/retest |
Tests are green, I think we should not rely on check for dedicated packages (see the |
@saschagrunert -- Feel free to handle in a follow-up! :) |
Looks like I accidentally removed the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, justaugustus, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
We re-enable the commented out binary and package checks because the
packages are now available in the CI.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Needs: #1170
Does this PR introduce a user-facing change?: