Set ReleaseVersion for generated notes #1217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
area/release-eng
|
/test pull-release-test |
|
This is failing for the same reason that #1180 is failing. It looks like it tries to pull the latest alpha +1, but the test data is hard coded to |
We need to set the ReleaseVersion within the JSON for the generated notes to display them correctly on relnotes.k8s.io. Signed-off-by: Sascha Grunert <[email protected]>
|
woot /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jeefy, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
We need to set the ReleaseVersion within the JSON for the generated
notes to display them correctly on relnotes.k8s.io.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
/cc @evillgenius75 @JamesLaverack @reylejano-rxm @jluk @puerco
Does this PR introduce a user-facing change?