Skip to content

[VDF] Partial revert of k8s.gcr.io cutover #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

justaugustus
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This partially reverts commits:

From @listx on k-dev:

We found a hard-coded internal reference that we had missed which
caused some large fraction of traffic from certain regions to be sent to
the wrong place. Because it is Friday afternoon, we will halt the
rollout, do a fast rollback, and try again early next week. Sorry!

Signed-off-by: Stephen Augustus [email protected]

/assign @tpepper @hasheddan @saschagrunert @cpanato
cc: @kubernetes/release-engineering
/priority critical-urgent

Special notes for your reviewer:

I've kept the manifest validation logic in here from #1199 and only reverted the project/bucket changes.

Does this PR introduce a user-facing change?

[VDF] Partial revert of k8s.gcr.io cutover

This partially reverts commits:
- 29b8e1d
- 4343e86
- dcaf5c0

From Linus:
"We found a hard-coded internal reference that we had missed which
caused some large fraction of traffic from certain regions to be sent to
the wrong place. Because it is Friday afternoon, we will halt the
rollout, do a fast rollback, and try again early next week. Sorry!"

Signed-off-by: Stephen Augustus <[email protected]>
@k8s-ci-robot
Copy link
Contributor

@justaugustus: Adding label: do-not-merge/blocked-paths because PR changes a protected file.

Reasons for blocking this PR:

[Changes to certain release tools can affect our ability to test, build, and release Kubernetes. This PR must be explicitly approved by SIG Release repo admins.]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label Apr 3, 2020
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 3, 2020
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 3, 2020
@justaugustus justaugustus removed the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label Apr 3, 2020
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b60c168 into kubernetes:master Apr 3, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Apr 3, 2020
justaugustus added a commit to justaugustus/release that referenced this pull request Apr 3, 2020
This reverts commit b60c168, reversing
changes made to 2614864.
justaugustus added a commit to justaugustus/release that referenced this pull request May 11, 2020
This reverts commit b60c168, reversing
changes made to 2614864.
justaugustus added a commit to justaugustus/release that referenced this pull request May 20, 2020
This reverts commit b60c168, reversing
changes made to 2614864.
justaugustus added a commit to justaugustus/release that referenced this pull request Jun 23, 2020
This reverts commit b60c168, reversing
changes made to 2614864.
justaugustus added a commit to justaugustus/release that referenced this pull request Jun 23, 2020
This reverts commit b60c168, reversing
changes made to 2614864.
justaugustus added a commit to justaugustus/release that referenced this pull request Jul 18, 2020
This reverts commit b60c168, reversing
changes made to 2614864.
justaugustus added a commit to justaugustus/release that referenced this pull request Jul 20, 2020
This reverts commit b60c168, reversing
changes made to 2614864.
justaugustus added a commit to justaugustus/release that referenced this pull request Jul 21, 2020
This reverts commit b60c168, reversing
changes made to 2614864.
puerco pushed a commit to puerco/release that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants