Skip to content

images: add skopeo binary for the 1.15 releases #1242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2020
Merged

images: add skopeo binary for the 1.15 releases #1242

merged 1 commit into from
Apr 16, 2020

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Apr 16, 2020

What type of PR is this?

/kind bug

What this PR does / why we need it:

Add skopeo binary in the builder image for 1.15 release

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

images: add skopeo binary for the 1.15 releases

/assign @justaugustus

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 16, 2020
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Apr 16, 2020
@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 16, 2020
saschagrunert
saschagrunert approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@saschagrunert
Copy link
Member

Okay, this is new:

Expected nil, but got: retrieving kube version: HTTP status not OK (404) for https://dl.k8s.io/ci/latest-1.14.txt

Looks like we're removing those files...

@justaugustus
Copy link
Member

/retest

@cpanato
Copy link
Member Author

cpanato commented Apr 16, 2020

needs #1243

@cpanato cpanato force-pushed the update-kube-cross-for-1.15 branch from 3674e2c to 346fd7d Compare April 16, 2020 15:04
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2020
@justaugustus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 14a4668 into kubernetes:master Apr 16, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Apr 16, 2020
@cpanato cpanato deleted the update-kube-cross-for-1.15 branch April 16, 2020 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@aleksandra-malinowska aleksandra-malinowska Awaiting requested review from aleksandra-malinowska

@ps882 ps882 Awaiting requested review from ps882

Assignees

@justaugustus justaugustus

@saschagrunert saschagrunert

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
4 participants
@cpanato @justaugustus @saschagrunert @k8s-ci-robot