Skip to content

Make release version retrieval tests independent from remote content #1244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2020
Merged

Make release version retrieval tests independent from remote content #1244

merged 1 commit into from
Apr 17, 2020

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Apr 17, 2020 •
edited
Loading

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

The tests are now HTTP mocked and return the pre-defined behavior. This
avoids future test failures inside that package.

Which issue(s) this PR fixes:

Follow up of #1243

Special notes for your reviewer:

I will follow-up with another PR in conjunction with the gcbmgr test.

Does this PR introduce a user-facing change?

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 17, 2020
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 17, 2020
@saschagrunert
Make release version retrieval tests independent up remote content
ed566ac 
The tests are now HTTP mocked and return the pre-defined behavior. This
avoids future test failures inside that package.

Signed-off-by: Sascha Grunert <[email protected]>
hasheddan
hasheddan approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2020
@k8s-ci-robot k8s-ci-robot merged commit 32faecc into kubernetes:master Apr 17, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Apr 17, 2020
@saschagrunert saschagrunert deleted the test-mock branch April 17, 2020 16:58
@saschagrunert saschagrunert changed the title Make release version retrieval tests independent up remote content Make release version retrieval tests independent from remote content Apr 20, 2020
@saschagrunert saschagrunert mentioned this pull request Apr 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus Awaiting requested review from justaugustus

1 more reviewer

@hasheddan hasheddan hasheddan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
3 participants
@saschagrunert @k8s-ci-robot @hasheddan