Skip to content

Finish repo state check in gcbmgr #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2020
Merged

Finish repo state check in gcbmgr #1254

merged 1 commit into from
May 7, 2020

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Apr 27, 2020 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

The CheckState method of the repository package now verifies that
the latest remote commit is available in the local repository.

For that a new git API repository method Branch() has been added as
well.

Which issue(s) this PR fixes:

Follow-up of #1252

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

- `krel gcbmgr` now validates that the latest remote commit of the release repository
  is available in the local repository checkout. To ensure that a new `git` API
  method `Branch()` has been added as well.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 27, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Apr 27, 2020
@saschagrunert
Finish repo state check in gcbmgr
7aa6e04 
The `CheckState` method of the `repository` package now verifies that
the latest remote commit is available in the local repository.

For that a new `git` API repository method `Branch()` has been added as
well.

Signed-off-by: Sascha Grunert <[email protected]>
@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7fa1431 into kubernetes:master May 7, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 7, 2020
@saschagrunert saschagrunert deleted the repo-state branch May 7, 2020 07:51
@justaugustus justaugustus mentioned this pull request May 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoegaarden hoegaarden Awaiting requested review from hoegaarden

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@justaugustus justaugustus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
3 participants
@saschagrunert @justaugustus @k8s-ci-robot