kube-cross: Build v1.14.2-3 and v1.13.9-4 images #1264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency updates: - PROTOBUF_VERSION to 3.11.4 - ETCD_VERSION to v3.4.7 - SKOPEO_VERSION to v0.2.0 Signed-off-by: Stephen Augustus <[email protected]>
Here we explicitly provide fake values for each of the variables in the kube-cross GCB config to prevent accidental builds that circumvent the Makefile or variants.yaml configs. Signed-off-by: Stephen Augustus <[email protected]>
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
the
approved
|
Failure on the go1.13 run seems to be a network error; rerunning here: https://console.cloud.google.com/cloud-build/builds/5f51199e-342a-434d-8a6f-fc6e995efeab?project=k8s-staging-build-image |
|
Test image builds are passing. |
k8s-ci-robot
added
priority/important-soon
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
kube-cross: Build v1.14.2-3 and v1.13.9-4 images
Dependency updates:
kube-cross: Zero out substitution values in GCB config
Here we explicitly provide fake values for each of the variables in the
kube-cross GCB config to prevent accidental builds that circumvent the
Makefile or variants.yaml configs.
Special notes for your reviewer:
/hold for testing
Does this PR introduce a user-facing change?