Skip to content

Remove deprecated FormatSpecMarkdown from notes options #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2020
Merged

Remove deprecated FormatSpecMarkdown from notes options #1271

merged 1 commit into from
May 8, 2020

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented May 8, 2020

What type of PR is this?

/kind api-change

What this PR does / why we need it:

We now cleanup the rendering options and remove the deprecated
FormatSpecMarkdown. The release-notes (non krel) tool has been
adapted as well.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

- Added `--format go-template:inline:<template-string> options to `release-notes` tool
- Removed deprecated `FormatSpecMarkdown` from `options` package

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject labels May 8, 2020
@k8s-ci-robot k8s-ci-robot requested review from jeefy and justaugustus May 8, 2020 08:19
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 8, 2020
We now cleanup the rendering options and remove the deprecated
`FormatSpecMarkdown`. The `release-notes` (non krel) tool has been
adapted as well.

Signed-off-by: Sascha Grunert <[email protected]>
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b5c2fb5 into kubernetes:master May 8, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 8, 2020
@saschagrunert saschagrunert deleted the deprecate branch May 8, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants