Skip to content

dependencies: Update several dependencies #1301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2020

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented May 19, 2020

/hold

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Update dependencies:

  • Update github.com/bazelbuild/rules_go dependency to v0.23.1 which is the latest available and has the following changes
  • Update github.com/maxbrunsfeld/counterfeiter/v6 dependency to v6.2.3 which is the latest available and has the following changes
  • Update github.com/psampaz/go-mod-outdated dependency to v0.6.0 which is the latest available and has the following changes
  • Update github.com/spf13/cobra dependency to v1.0.0 which is the latest available and has the following changes
  • Update github.com/yuin/goldmark dependency to v1.1.30 which is the latest available and has the following changes
  • Update k8s.io/utils dependency to v0.0.0-20200414100711-2df71ebbae66

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

- Update github.com/bazelbuild/rules_go dependency to v0.23.1
- Update github.com/maxbrunsfeld/counterfeiter/v6 dependency to v6.2.3
- Update github.com/psampaz/go-mod-outdated dependency to v0.6.0
- Update github.com/spf13/cobra dependency to v1.0.0
- Update github.com/yuin/goldmark dependency to v1.1.30
- Update k8s.io/utils dependency to v0.0.0-20200414100711-2df71ebbae66

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 19, 2020
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels May 19, 2020
@cpanato
Copy link
Member Author

cpanato commented May 19, 2020

/test all

@justaugustus justaugustus marked this pull request as ready for review May 19, 2020 12:07
@justaugustus
Copy link
Member

/hold until after tomorrow's patch releases

@cpanato
Copy link
Member Author

cpanato commented May 19, 2020

@justaugustus i'm still testing that :) no rush at all

@cpanato cpanato force-pushed the update branch 2 times, most recently from d4af24c to 9e5fdfb Compare May 19, 2020 12:54
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 19, 2020
- Update `github.com/bazelbuild/rules_go` dependency to [v0.23.1](https://github.com/bazelbuild/rules_go/tree/v0.23.1) which is the latest available and has the [following changes](https://github.com/bazelbuild/rules_go/releases/tag/v0.23.1)
- Update `github.com/maxbrunsfeld/counterfeiter/v6` dependency to [v6.2.3](https://github.com/maxbrunsfeld/counterfeiter/tree/v6.2.3) which is the latest available and has the [following changes](https://github.com/maxbrunsfeld/counterfeiter/releases/tag/v6.2.3)
- Update `github.com/psampaz/go-mod-outdated` dependency to [v0.6.0](https://github.com/psampaz/go-mod-outdated/tree/v0.6.0) which is the latest available and has the [following changes](https://github.com/psampaz/go-mod-outdated/releases/tag/v0.6.0)
- Update `github.com/spf13/cobra` dependency to [v1.0.0](https://github.com/spf13/cobra/tree/v1.0.0) which is the latest available and has the [following changes](https://github.com/spf13/cobra/releases/tag/v1.0.0)
- Update `github.com/yuin/goldmark` dependency to [v1.1.30](https://github.com/yuin/goldmark/tree/v1.1.30) which is the latest available and has the [following changes](https://github.com/yuin/goldmark/releases/tag/v1.1.30)
- Update `k8s.io/utils` dependency to `v0.0.0-20200414100711-2df71ebbae66`
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 19, 2020
@cpanato cpanato changed the title WIP update several deps dependencies: Update several dependencies May 19, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 19, 2020
@cpanato
Copy link
Member Author

cpanato commented May 19, 2020

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority labels May 19, 2020
@cpanato
Copy link
Member Author

cpanato commented May 19, 2020

/test pull-release-cluster-up

@cpanato
Copy link
Member Author

cpanato commented May 19, 2020

all good for review @justaugustus @saschagrunert

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
:)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2020
@justaugustus
Copy link
Member

/lgtm
/approve

@justaugustus
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2020
@k8s-ci-robot k8s-ci-robot merged commit 3544be5 into kubernetes:master May 21, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 21, 2020
@cpanato cpanato deleted the update branch May 21, 2020 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants